It is not an easy matter to develop problems which help students understand mathematical concepts correctly and precisely. The aim of this paper is to review the merits and demerits of three problem types (i.e. one answer problems, multiple choice problems and proof problems) and to suggest some points that should be taken into consideration in problem making. First, we presented the merits and demerits of three types of problems by examining actual examples. Second, we discussed some examples of misleading problems and the ways to make desirable ones. Finally, on the basis of our examination and discussion, we suggested some points that should be kept in mind in problem making. The major suggestions are as follows; i) In making one answer problems, we should consider the possibility of sitting a solution by wrong precesses, ii) In formulating multiple choice tests which are layered for their easiness of grading, we should take into account the importance of checking whether the students are fully understanding the concepts, iii) We may depend on the previous research result that multiple choice tests for proof problems can be helpful for the students who have insufficient math background. Besides those suggestions, we made an overall proposal that we should endeavor to find ways to implement the demerits of each problem type and to develop instructive problems that can help students understanding of math.